NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Minecraft 1.11.2 wrappers #234

Closed ExE-Boss closed 5 years ago

ExE-Boss commented 7 years ago

I’ve begun work on wrappers for Minecraft 1.11.

Depends on:

To do list:

Completed:


Moved from: #231 P.S.: I will do my best to not let NOVA die just yet, I just hope that life won’t get in the way of that.

codecov-io commented 7 years ago

Codecov Report

Merging #234 into master will decrease coverage by 3.7%. The diff coverage is 1.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #234      +/-   ##
============================================
- Coverage     16.97%   13.26%   -3.71%     
- Complexity      965     1005      +40     
============================================
  Files           416      532     +116     
  Lines         13176    17357    +4181     
  Branches       1382     1804     +422     
============================================
+ Hits           2236     2302      +66     
- Misses        10794    14908    +4114     
- Partials        146      147       +1
Impacted Files Coverage Δ Complexity Δ
...11_2/wrapper/render/forward/FWSmartBlockModel.java 0% <0%> (ø) 0 <0> (?)
..._11_2/wrapper/recipes/MinecraftRecipeRegistry.java 0% <0%> (ø) 0 <0> (?)
...e/v1_11_2/wrapper/block/forward/FWTileUpdater.java 0% <0%> (ø) 0 <0> (?)
...mc/forge/v1_11_2/wrapper/block/forward/FWTile.java 0% <0%> (ø) 0 <0> (?)
.../forge/v1_11_2/network/netty/MCNetworkManager.java 0% <0%> (ø) 0 <0> (?)
...11_2/wrapper/entity/forward/MCEntityTransform.java 0% <0%> (ø) 0 <0> (?)
...re/wrapper/mc/forge/v1_11_2/NovaMinecraftCore.java 0% <0%> (ø) 0 <0> (?)
...r/mc/forge/v1_11_2/wrapper/item/ItemConverter.java 0% <0%> (ø) 0 <0> (?)
...1_2/wrapper/recipes/forward/ShapedRecipeBasic.java 0% <0%> (ø) 0 <0> (?)
.../v1_11_2/wrapper/particle/backward/BWParticle.java 0% <0%> (ø) 0 <0> (?)
... and 686 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59455b7...78c87a1. Read the comment docs.

RX14 commented 7 years ago

Ignore coverage for this PR because it's a MC wrapper. I'll merge it regardless.

calclavia commented 7 years ago

@RX14 Should we add @ExE-Boss as a contributor? He's made a decent amount of PRs

RX14 commented 7 years ago

@calclavia He is, I've made it so that all commits to the master branch need to be reviewed though.

loordgek commented 7 years ago

@ExE-Boss do you know that MC itemstack cannot be null?? do you know how the Capability stuff works?(it is realy cool)

ExE-Boss commented 7 years ago

@loordgek I am aware of both (I just forgot to push the non-null ItemStack fix for over a month).