[RFC] Move all remaining events to their correct event class as inner classes

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system

https://nova-team.github.io

GNU Lesser General Public License v3.0

66 stars 23 forks source link

[RFC] Move all remaining events to their correct event class as inner classes #253

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

Resolves #192 and completes #233.

Completed:

[x] Move RecipeAddedEvent to RecipeEvent as RecipeEvent.Add
[x] Move RecipeRemovedEvent to RecipeEvent as RecipeEvent.Remove
[x] Made RecipeEvent.Add and RecipeEvent.Remove extend RecipeEvent
[x] Made RecipeEvent extend CancelableEvent

No more orphaned event classes have been found. Events in Block, Item and Entity were left there, as they are bound to the Block, Item or Entity instance.

codecov-io commented 7 years ago

Current coverage is 14.17% (diff: 10.00%)

Merging #253 into master will decrease coverage by 0.01%

@@             master       #253   diff @@
==========================================
  Files           395        394     -1   
  Lines         11148      11150     +2   
  Methods           0          0          
  Messages          0          0          
  Branches       1586       1586          
==========================================
- Hits           1582       1581     -1   
- Misses         9480       9483     +3   
  Partials         86         86

Powered by Codecov. Last update 8ec2f06...f422465