search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Remove Loadable #256

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

Resolves #248.

codecov-io commented 7 years ago

Codecov Report

Merging #256 into master will increase coverage by -0.15%.

@@             Coverage Diff              @@
##             master     #256      +/-   ##
============================================
- Coverage     13.79%   13.65%   -0.15%     
- Complexity        0      652     +652     
============================================
  Files           394      395       +1     
  Lines         11414    11387      -27     
  Branches       1669     1246     -423     
============================================
- Hits           1575     1555      -20     
+ Misses         9737     9734       -3     
+ Partials        102       98       -4
Impacted Files Coverage Δ Complexity Δ
...e/wrapper/mc/forge/v17/launcher/ForgeLoadable.java 0% <ø> (ø) 0 <ø> (?)
...e/wrapper/mc/forge/v17/launcher/NovaMinecraft.java 0% <ø> (ø) 0 <ø> (ø) :x:
...apper/mc/forge/v18/wrapper/item/ItemConverter.java 0% <ø> (ø) 0 <ø> (ø) :x:
...r/mc/forge/v17/wrapper/entity/EntityConverter.java 0% <ø> (ø) 0 <ø> (ø) :x:
...r/mc/forge/v18/wrapper/entity/EntityConverter.java 0% <ø> (ø) 0 <ø> (ø) :x:
...apper/mc/forge/v17/wrapper/item/ItemConverter.java 0% <ø> (ø) 0 <ø> (ø) :x:
...e/wrapper/mc/forge/v18/launcher/ForgeLoadable.java 0% <ø> (ø) 0 <ø> (?)
...per/mc/forge/v17/wrapper/block/BlockConverter.java 0% <ø> (ø) 0 <ø> (ø) :x:
...ore/wrapper/mc/forge/v17/launcher/CommonProxy.java 0% <ø> (ø) 0 <ø> (ø) :x:
...ore/wrapper/mc/forge/v18/launcher/CommonProxy.java 0% <ø> (ø) 0 <ø> (ø) :x:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93020d5...c085f46. Read the comment docs.

calclavia commented 7 years ago

Just to be clear, ForgeLoadable replaced Loadable. Does this mean the client mod does not need to "know about" or be "coupled" with loading logic?

ExE-Boss commented 7 years ago

@calclavia If client mod refers to a NOVA mod, then yes, as NOVA mods now listen for Manager.Init events and register stuff there, but without knowing what loading stage that happens in, only the order (LanguageManager → RenderManager → BlockManager → ItemManager → EntityManager → RecipeManager). ForgeLoadable is used by wrappers to fire their own Manager.Init events at the correct time and by NativeConveters to handle conversion at the correct time.