search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Move language handling to NOVA side #258

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

Currently language handling is done on Minecraft side, this can cause issues, especially in Minecraft 1.11, where some language methods were removed (ex. LanguageRegistry.instance().addStringLocalization(String, String, String)). This PR also allows mods to specify the unlocalized and localized names of blocks and items, which was previously done on Minecraft side.

To do list:

codecov-io commented 7 years ago

Codecov Report

Merging #258 into master will decrease coverage by -0.35%. The diff coverage is 25%.

@@             Coverage Diff              @@
##             master     #258      +/-   ##
============================================
- Coverage     13.43%   13.09%   -0.35%     
- Complexity      664      674      +10     
============================================
  Files           401      406       +5     
  Lines         11724    12251     +527     
  Branches       1254     1387     +133     
============================================
+ Hits           1575     1604      +29     
- Misses        10051    10548     +497     
- Partials         98       99       +1
Impacted Files Coverage Δ Complexity Δ
...rapper/mc/forge/v17/depmodules/LanguageModule.java 100% <ø> (ø) 2 <ø> (ø) :x:
src/main/java/nova/internal/core/Game.java 73.46% <ø> (ø) 11 <ø> (ø) :x:
...rapper/mc/forge/v18/depmodules/LanguageModule.java 100% <ø> (ø) 2 <ø> (ø) :x:
src/main/java/nova/core/item/ItemBlock.java 0% <ø> (ø) 0 <ø> (ø) :x:
...er/mc/forge/v17/wrapper/block/forward/FWBlock.java 0% <ø> (ø) 0 <ø> (ø) :x:
src/main/java/nova/core/event/LanguageEvent.java 0% <ø> (ø) 0 <ø> (?)
...wrapper/mc/forge/v18/wrapper/item/FWItemBlock.java 0% <ø> (ø) 0 <ø> (ø) :x:
...core/wrapper/mc/forge/v18/wrapper/item/FWItem.java 0% <ø> (ø) 0 <ø> (ø) :x:
src/main/java/nova/core/item/Item.java 0% <ø> (ø) 0 <ø> (ø) :x:
...er/mc/forge/v18/wrapper/block/forward/FWBlock.java 0% <ø> (ø) 0 <ø> (ø) :x:
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37efba3...e346af2. Read the comment docs.