NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Make Orientation respect the mask and make it a Predicate #260

Closed ExE-Boss closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #260 into master will decrease coverage by -0.42%. The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #260      +/-   ##
============================================
- Coverage     13.54%   13.12%   -0.42%     
- Complexity      664      714      +50     
============================================
  Files           398      398              
  Lines         11631    12836    +1205     
  Branches       1249     1453     +204     
============================================
+ Hits           1575     1685     +110     
- Misses         9958    11048    +1090     
- Partials         98      103       +5
Impacted Files Coverage Δ Complexity Δ
...ava/nova/core/component/transform/Orientation.java 0% <ø> (ø) 0 <ø> (ø) :x:
...in/java/nova/core/component/ComponentProvider.java 58.73% <ø> (-11.27%) 3% <ø> (+1%)
...c/main/java/nova/core/component/misc/Collider.java 32.5% <ø> (-3.87%) 4% <ø> (+2%)
src/main/java/nova/core/util/RayTracer.java 63.69% <ø> (-1.14%) 46% <ø> (+22%)
src/main/java/nova/core/component/Component.java 44.44% <ø> (-1.02%) 4% <ø> (+1%)
src/main/java/nova/core/item/Item.java 0% <ø> (ø) 0% <ø> (ø) :x:
.../forge/v18/wrapper/block/forward/FWTileLoader.java 0% <ø> (ø) 0% <ø> (ø) :x:
...nova/core/render/pipeline/BlockRenderPipeline.java 0% <ø> (ø) 0% <ø> (ø) :x:
...a/core/wrapper/mc/forge/v17/util/WrapperEvent.java 0% <ø> (ø) 0% <ø> (ø) :x:
...c/forge/v17/wrapper/entity/forward/FWEntityFX.java 0% <ø> (ø) 0% <ø> (ø) :x:
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c357e1a...be638b2. Read the comment docs.

RX14 commented 7 years ago

Otherwise looks good to squash + merge