search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Implement Sided Components #261

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR implements sided components. This allows for Blocks to have specific components on one side only. Required for Minecraft 1.9+ wrappers for compatibility with Forge’s Capabilities.

codecov-io commented 7 years ago

Codecov Report

Merging #261 into master will decrease coverage by -0.39%. The diff coverage is 37.96%.

@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
- Coverage     13.46%   13.08%   -0.39%     
- Complexity      652      670      +18     
============================================
  Files           395      398       +3     
  Lines         11549    12184     +635     
  Branches       1249     1338      +89     
============================================
+ Hits           1555     1594      +39     
- Misses         9896    10493     +597     
+ Partials         98       97       -1
Impacted Files Coverage Δ Complexity Δ
...in/java/nova/core/component/renderer/Renderer.java 0% <ø> (ø) 0 <ø> (ø) :x:
...c/main/java/nova/core/entity/component/Living.java 0% <ø> (ø) 0 <ø> (ø) :x:
.../nova/core/component/renderer/DynamicRenderer.java 0% <ø> (ø) 0 <ø> (ø) :x:
...ain/java/nova/core/entity/component/RigidBody.java 0% <ø> (ø) 0 <ø> (ø) :x:
...in/java/nova/core/block/component/Connectable.java 0% <ø> (ø) 0 <ø> (ø) :x:
...java/nova/core/component/misc/FactoryProvider.java 100% <ø> (ø) 1 <ø> (ø) :x:
...main/java/nova/core/component/misc/Damageable.java 0% <ø> (ø) 0 <ø> (ø) :x:
...rapper/mc/forge/v18/asm/lib/ComponentInjector.java 0% <ø> (ø) 0 <ø> (ø) :x:
.../java/nova/core/block/component/BlockProperty.java 0% <ø> (ø) 0 <ø> (ø) :x:
...a/nova/core/component/renderer/StaticRenderer.java 0% <ø> (ø) 0 <ø> (ø) :x:
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aaccb91...278755d. Read the comment docs.