search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Fix NPE in NovaModContainer #262

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR fixes a NullPointerException thrown by Minecraft Forge when a crash would happen, because NovaModContainer.getSource() returns null.

codecov-io commented 7 years ago

Codecov Report

Merging #262 into master will decrease coverage by -0.5%. The diff coverage is 0%.

@@             Coverage Diff             @@
##             master     #262     +/-   ##
===========================================
- Coverage     13.46%   12.97%   -0.5%     
- Complexity      652      658      +6     
===========================================
  Files           395      395             
  Lines         11549    12134    +585     
  Branches       1249     1342     +93     
===========================================
+ Hits           1555     1574     +19     
- Misses         9896    10463    +567     
+ Partials         98       97      -1
Impacted Files Coverage Δ Complexity Δ
...e/wrapper/mc/forge/v18/NovaMinecraftPreloader.java 0% <ø> (ø) 0 <ø> (ø) :x:
...e/wrapper/mc/forge/v17/NovaMinecraftPreloader.java 0% <ø> (ø) 0 <ø> (ø) :x:
...mc/forge/v18/wrapper/entity/backward/BWEntity.java 0% <ø> (ø) 0% <ø> (ø) :x:
.../forge/v18/wrapper/entity/backward/BWEntityFX.java 0% <ø> (ø) 0% <ø> (ø) :x:
...apper/mc/forge/v17/wrapper/item/ItemConverter.java 0% <ø> (ø) 0% <ø> (ø) :x:
.../mc/forge/v18/wrapper/entity/forward/FWEntity.java 0% <ø> (ø) 0% <ø> (ø) :x:
...apper/mc/forge/v18/wrapper/item/ItemConverter.java 0% <ø> (ø) 0% <ø> (ø) :x:
...a/core/wrapper/mc/forge/v18/util/WrapperEvent.java 0% <ø> (ø) 0% <ø> (ø) :x:
...r/mc/forge/v18/wrapper/block/backward/BWBlock.java 0% <ø> (ø) 0% <ø> (ø) :x:
...e/wrapper/mc/forge/v18/launcher/NovaMinecraft.java 0% <ø> (ø) 0% <ø> (ø) :x:
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aaccb91...df03850. Read the comment docs.