search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Fix BlockProperty #264

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR fixes Soni's weirdness from #226 (which would cause a NullPointerException and an IllegalArgumenException once my assets rewrite would be fully implemented) and implements BlockProperty.Replaceable. It also fixes block place sounds.

codecov-io commented 7 years ago

Codecov Report

Merging #264 into master will decrease coverage by -0.08%. The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #264      +/-   ##
============================================
- Coverage     13.43%   13.36%   -0.08%     
  Complexity      664      664              
============================================
  Files           401      403       +2     
  Lines         11724    11787      +63     
  Branches       1254     1256       +2     
============================================
  Hits           1575     1575              
- Misses        10051    10114      +63     
  Partials         98       98
Impacted Files Coverage Δ Complexity Δ
src/main/java/nova/core/item/ItemBlock.java 0% <ø> (ø) 0 <ø> (ø) :x:
...er/mc/forge/v17/wrapper/block/forward/FWBlock.java 0% <ø> (ø) 0 <ø> (ø) :x:
...forge/v17/wrapper/block/forward/ProxyMaterial.java 0% <ø> (ø) 0 <ø> (?)
...pper/mc/forge/v17/wrapper/block/world/BWWorld.java 0% <ø> (ø) 0 <ø> (ø) :x:
src/main/java/nova/core/sound/Sound.java 0% <ø> (ø) 0 <ø> (ø) :x:
.../forge/v18/wrapper/block/forward/FWBlockSound.java 0% <ø> (ø) 0 <ø> (ø) :x:
.../java/nova/core/block/component/BlockProperty.java 0% <ø> (ø) 0 <ø> (ø) :x:
...r/mc/forge/v18/wrapper/block/backward/BWBlock.java 0% <ø> (ø) 0 <ø> (ø) :x:
...er/mc/forge/v18/wrapper/block/forward/FWBlock.java 0% <ø> (ø) 0 <ø> (ø) :x:
...n/java/nova/core/block/component/LightEmitter.java 0% <ø> (ø) 0 <ø> (ø) :x:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37efba3...829dd61. Read the comment docs.