search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Complete assets rewrite #265

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR rewrites the Assets to be case insensitive and let Texture extend Asset. Also fixes entity textures not working on Minecraft 1.7.10. Another feature is that RenderManager is now no longer abstract.

It took me two days to write this.

codecov-io commented 7 years ago

Codecov Report

Merging #265 into master will decrease coverage by -0.25%. The diff coverage is 1.94%.

@@             Coverage Diff              @@
##             master     #265      +/-   ##
============================================
- Coverage     13.63%   13.38%   -0.25%     
+ Complexity      682      679       -3     
============================================
  Files           405      403       -2     
  Lines         11913    12078     +165     
  Branches       1263     1296      +33     
============================================
- Hits           1624     1617       -7     
- Misses        10190    10362     +172     
  Partials         99       99
Impacted Files Coverage Δ Complexity Δ
src/main/java/nova/core/sound/Sound.java 0% <ø> (ø) 0 <0> (ø) :x:
...e/wrapper/mc/forge/v18/NovaMinecraftPreloader.java 0% <0%> (ø) 0 <0> (ø) :x:
...forge/v18/wrapper/assets/NovaFileResourcePack.java 0% <0%> (ø) 0 <0> (?)
...va/nova/core/render/model/TechneModelProvider.java 0% <0%> (ø) 0 <0> (ø) :x:
...rc/main/java/nova/core/render/texture/Texture.java 0% <0%> (ø) 0 <0> (ø) :x:
src/main/java/nova/core/util/Asset.java 0% <0%> (ø) 0 <0> (?)
.../nova/core/render/pipeline/ItemRenderPipeline.java 0% <0%> (ø) 0 <0> (ø) :x:
.../mc/forge/v18/wrapper/assets/NovaResourcePack.java 0% <0%> (ø) 0 <0> (?)
...e/wrapper/mc/forge/v18/launcher/NovaMinecraft.java 2.54% <0%> (ø) 2 <0> (ø) :x:
...ore/render/model/WavefrontObjectModelProvider.java 0% <0%> (ø) 0 <0> (ø) :x:
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9fd9be...3abad09. Read the comment docs.