search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Fix ore dictionary integration #268

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR fixes ore dictionary integration. Previously, ore dictionary registration was forwarded only from NOVA to Forge, but not from Forge to NOVA. I also moved dictionary events into their own class.

codecov-io commented 7 years ago

Codecov Report

Merging #268 into master will decrease coverage by -0.04%. The diff coverage is 3.44%.

@@             Coverage Diff              @@
##             master     #268      +/-   ##
============================================
- Coverage     13.49%   13.45%   -0.04%     
  Complexity      674      674              
============================================
  Files           405      406       +1     
  Lines         11879    11897      +18     
  Branches       1258     1246      -12     
============================================
- Hits           1603     1601       -2     
- Misses        10177    10197      +20     
  Partials         99       99
Impacted Files Coverage Δ Complexity Δ
...apper/mc/forge/v18/wrapper/item/ItemConverter.java 0% <ø> (ø) 0 <ø> (ø) :x:
...apper/mc/forge/v17/wrapper/item/ItemConverter.java 0% <ø> (ø) 0 <ø> (ø) :x:
src/main/java/nova/core/event/DictionaryEvent.java 0% <ø> (ø) 0 <ø> (?)
...rge/v17/wrapper/item/OreDictionaryIntegration.java 0% <ø> (ø) 0 <ø> (ø) :x:
...rge/v18/wrapper/item/OreDictionaryIntegration.java 0% <ø> (ø) 0 <ø> (ø) :x:
src/main/java/nova/core/util/Dictionary.java 10.25% <12%> (-5.96%) 1 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4872e5f...1881bfb. Read the comment docs.