search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Fix ComponentException when calling getID() on a BWBlock through World.getBlock() #270

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR fixes BWBlocks which were gained through World.getBlock() not having FactoryProvider.

codecov-io commented 7 years ago

Codecov Report

Merging #270 into master will decrease coverage by -0.01%. The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #270      +/-   ##
============================================
- Coverage     13.49%   13.48%   -0.01%     
  Complexity      674      674              
============================================
  Files           405      405              
  Lines         11879    11885       +6     
  Branches       1258     1258              
============================================
  Hits           1603     1603              
- Misses        10177    10183       +6     
  Partials         99       99
Impacted Files Coverage Δ Complexity Δ
...pper/mc/forge/v18/wrapper/block/world/BWWorld.java 0% <ø> (ø) 0 <ø> (ø) :x:
...pper/mc/forge/v17/wrapper/block/world/BWWorld.java 0% <ø> (ø) 0 <ø> (ø) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4872e5f...1792331. Read the comment docs.