Open ExE-Boss opened 7 years ago
Merging #271 into master will increase coverage by
0.16%
. The diff coverage is21.17%
.
@@ Coverage Diff @@
## master #271 +/- ##
============================================
+ Coverage 13.58% 13.74% +0.16%
- Complexity 732 762 +30
============================================
Files 409 413 +4
Lines 12788 13010 +222
Branches 1354 1380 +26
============================================
+ Hits 1737 1788 +51
- Misses 10934 11107 +173
+ Partials 117 115 -2
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
.../main/java/nova/core/util/unit/UnitConversion.java | 0% <0%> (ø) |
0 <0> (?) |
|
src/main/java/nova/core/util/unit/UnitDisplay.java | 0% <0%> (ø) |
0 <0> (?) |
|
src/main/java/nova/core/util/unit/Unit.java | 0% <0%> (ø) |
0 <0> (?) |
|
src/main/java/nova/core/util/unit/UnitPrefix.java | 100% <100%> (ø) |
10 <10> (?) |
|
src/main/java/nova/core/util/math/MathUtil.java | 86.17% <81.48%> (+4.08%) |
65 <18> (+20) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f8daac6...9eda38e. Read the comment docs.
Changes implemented and rebased to master
This PR will move
Unit
from Energy to Core.Reason:
Unit
seems like a class that would benefit more from being in Core than in Energy.Other changes:
UnitDisplay
is now immutable, and accepts aDoubleSupplier
to allow linking to a getter. Example:Modded Minecraft energy units were left out and will be added by NOVA-Team/NOVA-Energy#3.