search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Fix Translateable typo, and ease usage of translation replacements #272

Closed ExE-Boss closed 7 years ago

RX14 commented 7 years ago

An example of usage?

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@063b82a). Click here to learn what that means. The diff coverage is 56.66%.

@@            Coverage Diff            @@
##             master     #272   +/-   ##
=========================================
  Coverage          ?   13.62%           
  Complexity        ?      682           
=========================================
  Files             ?      405           
  Lines             ?    11912           
  Branches          ?     1263           
=========================================
  Hits              ?     1623           
  Misses            ?    10190           
  Partials          ?       99
Impacted Files Coverage Δ Complexity Δ
src/main/java/nova/core/block/BlockFactory.java 61.11% <0%> (ø) 3 <0> (?)
src/main/java/nova/core/item/ItemFactory.java 20.83% <0%> (ø) 2 <0> (?)
src/main/java/nova/core/item/Item.java 0% <0%> (ø) 0 <0> (?)
src/main/java/nova/core/block/Block.java 8.88% <50%> (ø) 3 <1> (?)
...rc/main/java/nova/core/language/Translateable.java 84.21% <84.21%> (ø) 6 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 063b82a...b01ce30. Read the comment docs.

ExE-Boss commented 7 years ago

An example of usage is in my testing block and item I use to test #252. (To display the name of the wrapped block, that is contained within the container so that I can know if it is working) I will push that soon as a new PR for NOVA-Example.