NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

FW rendering fixes #274

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR implements fixes for forward rendering.

List of fixes:

codecov-io commented 7 years ago

Codecov Report

Merging #274 into master will increase coverage by 0.16%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #274      +/-   ##
============================================
+ Coverage     13.61%   13.77%   +0.16%     
- Complexity      705      708       +3     
============================================
  Files           405      405              
  Lines         12287    12316      +29     
  Branches       1313     1312       -1     
============================================
+ Hits           1673     1697      +24     
- Misses        10497    10504       +7     
+ Partials        117      115       -2
Impacted Files Coverage Δ Complexity Δ
...pper/mc/forge/v18/wrapper/render/FWEmptyModel.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...r/mc/forge/v17/wrapper/block/backward/BWBlock.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...rc/main/java/nova/core/render/model/MeshModel.java 10.81% <ø> (ø) 0 <0> (ø) :arrow_down:
...r/mc/forge/v18/wrapper/block/backward/BWBlock.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
.../main/java/nova/core/render/model/CustomModel.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...e/wrapper/mc/forge/v17/wrapper/render/BWModel.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...ore/wrapper/mc/forge/v18/render/RenderUtility.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...er/mc/forge/v17/wrapper/block/forward/FWBlock.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...e/wrapper/mc/forge/v18/wrapper/render/BWModel.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../mc/forge/v18/wrapper/render/FWSmartItemModel.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed4eabd...c28d5a3. Read the comment docs.