search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Fix GlobalEvents.forMod setting wrong after values + Mod priority #280

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR fixes GlobalEvents.forMod setting the wrong after values and not setting the mod priority.

codecov-io commented 7 years ago

Codecov Report

Merging #280 into master will increase coverage by <.01%. The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #280      +/-   ##
============================================
+ Coverage     13.62%   13.62%   +<.01%     
- Complexity      682      685       +3     
============================================
  Files           405      406       +1     
  Lines         11912    11974      +62     
  Branches       1263     1264       +1     
============================================
+ Hits           1623     1632       +9     
- Misses        10190    10243      +53     
  Partials         99       99
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/nova/core/event/bus/GlobalEvents.java 91.66% <100%> (+0.75%) 5 <0> (ø) :x:
src/main/java/nova/core/block/BlockFactory.java 57.69% <0%> (-3.42%) 3% <0%> (ø)
src/main/java/nova/core/item/Item.java 0% <0%> (ø) 0% <0%> (ø) :x:
src/main/java/nova/core/language/Translatable.java 0% <0%> (ø) 0% <0%> (?)
src/main/java/nova/core/block/Block.java 11.26% <0%> (+2.37%) 6% <0%> (+3%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8704318...b7d820c. Read the comment docs.