search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Implement Vertex normals #282

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR implements per-vertex normals.

To do list:

Depends on:

codecov-io commented 7 years ago

Codecov Report

Merging #282 into master will decrease coverage by 0.04%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #282      +/-   ##
============================================
- Coverage     13.69%   13.64%   -0.05%     
  Complexity      711      711              
============================================
  Files           408      408              
  Lines         12466    12509      +43     
  Branches       1326     1329       +3     
============================================
  Hits           1707     1707              
- Misses        10643    10686      +43     
  Partials        116      116
Impacted Files Coverage Δ Complexity Δ
src/main/java/nova/core/render/model/Face.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...rc/main/java/nova/core/render/model/MeshModel.java 10% <0%> (-0.82%) 0 <0> (ø)
...pper/mc/forge/v18/wrapper/render/FWSmartModel.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...rc/main/java/nova/core/util/math/Vector3DUtil.java 40.74% <0%> (-11.65%) 8 <0> (ø)
...ore/render/model/WavefrontObjectModelProvider.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...e/wrapper/mc/forge/v17/wrapper/render/BWModel.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
src/main/java/nova/core/render/model/Vertex.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...e/wrapper/mc/forge/v18/wrapper/render/BWModel.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1471f81...04376b9. Read the comment docs.