search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Allow loading of NOVA language files #285

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR makes <IETF language tag>.lang files load on NOVA side instead of Minecraft side.

Also makes the NovaResourcePack interface extend the IResourcePack interface.

To do list:

codecov-io commented 7 years ago

Codecov Report

Merging #285 into master will increase coverage by 0.13%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #285      +/-   ##
============================================
+ Coverage     13.23%   13.37%   +0.13%     
- Complexity      684      726      +42     
============================================
  Files           405      408       +3     
  Lines         12198    13044     +846     
  Branches       1288     1407     +119     
============================================
+ Hits           1615     1744     +129     
- Misses        10482    11184     +702     
- Partials        101      116      +15
Impacted Files Coverage Δ Complexity Δ
.../mc/forge/v17/wrapper/assets/NovaResourcePack.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
.../mc/forge/v18/wrapper/assets/NovaResourcePack.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...rge/v18/wrapper/assets/NovaFolderResourcePack.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...e/wrapper/mc/forge/v18/NovaMinecraftPreloader.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...e/wrapper/mc/forge/v18/launcher/NovaMinecraft.java 2.47% <0%> (-0.03%) 2 <0> (ø)
...ore/wrapper/mc/forge/v18/launcher/CommonProxy.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...forge/v18/wrapper/assets/NovaFileResourcePack.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...e/wrapper/mc/forge/v17/NovaMinecraftPreloader.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...ore/wrapper/mc/forge/v17/launcher/CommonProxy.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...rge/v17/wrapper/assets/NovaFolderResourcePack.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42603ed...0a1edab. Read the comment docs.