search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Implement correct NOVA ID namespacing #288

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR implements correct NOVA ID namespacing.

Previously, if a NOVA mod with the ID example with the ID block, it would get registered as nova:example:block when registered in Minecraft 1.7 and 1.8.

With this PR merged, if a NOVA mod with the ID example with the ID block, it would get registered as example:block when registered in Minecraft 1.7 and 1.8.

This feature wasn't merged because of Soni’s less than helpful review at https://github.com/NOVA-Team/NOVA-Core/pull/235#pullrequestreview-15632981 and in the discussion past my pinned message from 01/09/2017 on the discord server.

Moved from #235

codecov-io commented 7 years ago

Codecov Report

Merging #288 into master will decrease coverage by 0.15%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #288      +/-   ##
============================================
- Coverage     13.61%   13.46%   -0.16%     
  Complexity      705      705              
============================================
  Files           405      407       +2     
  Lines         12287    12425     +138     
  Branches       1313     1327      +14     
============================================
  Hits           1673     1673              
- Misses        10497    10635     +138     
  Partials        117      117
Impacted Files Coverage Δ Complexity Δ
...apper/mc/forge/v18/wrapper/item/ItemConverter.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...orge/v17/asm/transformers/GameDataTransformer.java 0% <0%> (ø) 0 <0> (?)
...core/wrapper/mc/forge/v17/asm/StaticForwarder.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...core/wrapper/mc/forge/v18/asm/StaticForwarder.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...per/mc/forge/v18/wrapper/block/BlockConverter.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...orge/v18/asm/transformers/GameDataTransformer.java 0% <0%> (ø) 0 <0> (?)
...apper/mc/forge/v17/wrapper/item/ItemConverter.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...er/mc/forge/v17/asm/transformers/Transformers.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...per/mc/forge/v17/wrapper/block/BlockConverter.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...er/mc/forge/v18/asm/transformers/Transformers.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed4eabd...a8ddcca. Read the comment docs.