NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Move the block's associated TileEntity on block move #290

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR makes it so that when you call block.components.get(BlockTransform.class).setPosition(newPos) on a Stateful block, then the block's TileEntity gets moved with the block.

Complete:


Closes #143

codecov-io commented 7 years ago

Codecov Report

Merging #290 into master will decrease coverage by 0.21%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #290      +/-   ##
============================================
- Coverage     16.37%   16.16%   -0.22%     
  Complexity      897      897              
============================================
  Files           409      413       +4     
  Lines         12913    13084     +171     
  Branches       1356     1377      +21     
============================================
  Hits           2115     2115              
- Misses        10652    10823     +171     
  Partials        146      146
Impacted Files Coverage Δ Complexity Δ
...per/mc/forge/v18/wrapper/block/forward/FWTile.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...ge/v17/wrapper/block/forward/MCBlockTransform.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...ge/v18/wrapper/block/forward/TEBlockTransform.java 0% <0%> (ø) 0 <0> (?)
...ge/v18/wrapper/block/forward/MCBlockTransform.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...e/v18/wrapper/block/backward/BWBlockTransform.java 0% <0%> (ø) 0 <0> (?)
...r/mc/forge/v18/wrapper/block/backward/BWBlock.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...er/mc/forge/v18/wrapper/block/forward/FWBlock.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...per/mc/forge/v17/wrapper/block/forward/FWTile.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...ge/v17/wrapper/block/forward/TEBlockTransform.java 0% <0%> (ø) 0 <0> (?)
...r/mc/forge/v17/wrapper/block/backward/BWBlock.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c78fe20...42859ed. Read the comment docs.