Open ExE-Boss opened 7 years ago
Merging #291 into master will decrease coverage by
0.11%
. The diff coverage is10.52%
.
@@ Coverage Diff @@
## master #291 +/- ##
============================================
- Coverage 13.58% 13.46% -0.12%
- Complexity 732 736 +4
============================================
Files 409 412 +3
Lines 12788 12958 +170
Branches 1354 1375 +21
============================================
+ Hits 1737 1745 +8
- Misses 10934 11092 +158
- Partials 117 121 +4
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...n/java/nova/core/component/fluid/FluidHandler.java | 0% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
...in/java/nova/core/component/fluid/FluidFilter.java | 0% <0%> (ø) |
0 <0> (?) |
|
src/main/java/nova/core/component/fluid/Tank.java | 23.07% <0%> (-4.2%) |
4 <0> (ø) |
|
...e/wrapper/mc/forge/v18/launcher/NovaMinecraft.java | 2.45% <0%> (-0.03%) |
2 <0> (ø) |
|
.../nova/core/component/fluid/FluidHandlerSimple.java | 0% <0%> (ø) |
0 <0> (?) |
|
.../java/nova/core/component/fluid/FluidProvider.java | 50% <0%> (-50%) |
1 <0> (ø) |
|
...e/wrapper/mc/forge/v17/launcher/NovaMinecraft.java | 2.47% <0%> (-0.03%) |
2 <0> (ø) |
|
...nova/core/component/fluid/FluidHandlerWrapper.java | 0% <0%> (ø) |
0 <0> (?) |
|
...n/java/nova/core/component/fluid/FluidFactory.java | 35.71% <100%> (ø) |
2 <0> (ø) |
:arrow_down: |
...n/java/nova/core/component/fluid/FluidManager.java | 85.71% <100%> (+15.71%) |
4 <1> (+1) |
:arrow_up: |
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f8daac6...fb1e631. Read the comment docs.
This PR near-fully implements Fluids. Fluids are now registered in the following way:
To do list: