NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Improve ComponentException arguments #294

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR fixes the ComponentException message constructed as such:

throw new ComponentException("Issue with component %s on provider %s.", component, this);

getting logged as: Issue with component Component on provider [[Ljava.lang.Object;@33d8e330]. instead of as: Issue with component Component on provider Provider.

Also adds a missed @Test annotation to a method in NovaLauncherTest.

codecov-io commented 7 years ago

Codecov Report

Merging #294 into master will increase coverage by 0.1%. The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #294     +/-   ##
===========================================
+ Coverage     13.61%   13.71%   +0.1%     
- Complexity      705      710      +5     
===========================================
  Files           405      406      +1     
  Lines         12287    12298     +11     
  Branches       1313     1313             
===========================================
+ Hits           1673     1687     +14     
  Misses        10497    10497             
+ Partials        117      114      -3
Impacted Files Coverage Δ Complexity Δ
...in/java/nova/core/component/ComponentProvider.java 64.28% <0%> (ø) 3 <1> (ø) :arrow_down:
...rc/main/java/nova/core/component/ComponentMap.java 54.05% <100%> (ø) 10 <0> (ø) :arrow_down:
...a/core/component/exception/ComponentException.java 100% <100%> (ø) 2 <1> (ø) :arrow_down:
src/main/java/nova/core/util/ArrayUtil.java 90.9% <90.9%> (ø) 3 <3> (?)
...n/java/nova/internal/core/launch/NovaLauncher.java 60.78% <0%> (+2.61%) 32% <0%> (+2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed4eabd...3f82231. Read the comment docs.