NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Implement Generic Type Resolution for Factory creation. #295

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

See #292 for details.

To do list:


Resolves #292

codecov-io commented 7 years ago

Codecov Report

Merging #295 into master will increase coverage by 0.08%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #295      +/-   ##
============================================
+ Coverage     13.82%   13.91%   +0.08%     
- Complexity      710      715       +5     
============================================
  Files           406      406              
  Lines         12314    12329      +15     
  Branches       1317     1319       +2     
============================================
+ Hits           1703     1715      +12     
- Misses        10496    10498       +2     
- Partials        115      116       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/nova/core/util/registry/Factory.java 48.14% <66.66%> (+5.29%) 5 <1> (+1) :arrow_up:
.../main/java/nova/internal/core/di/LoggerModule.java 89.65% <0%> (-2.02%) 4% <0%> (+2%)
...a/core/component/exception/ComponentException.java 100% <0%> (ø) 4% <0%> (+2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6596ed...b96f4c8. Read the comment docs.