NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Mod specific logger is passed the mod's name instead of the class name #296

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

Completed:

codecov-io commented 7 years ago

Codecov Report

Merging #296 into master will increase coverage by 0.14%. The diff coverage is 90%.

@@             Coverage Diff              @@
##             master     #296      +/-   ##
============================================
+ Coverage     13.61%   13.76%   +0.14%     
- Complexity      705      707       +2     
============================================
  Files           405      405              
  Lines         12287    12303      +16     
  Branches       1313     1317       +4     
============================================
+ Hits           1673     1693      +20     
+ Misses        10497    10495       -2     
+ Partials        117      115       -2
Impacted Files Coverage Δ Complexity Δ
...in/java/nova/internal/core/util/InjectionUtil.java 39.28% <100%> (ø) 5 <1> (ø) :arrow_down:
.../main/java/nova/internal/core/di/LoggerModule.java 91.66% <89.47%> (+16.66%) 2 <1> (ø) :arrow_down:
...n/java/nova/internal/core/launch/NovaLauncher.java 60.78% <0%> (+2.61%) 32% <0%> (+2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed4eabd...1b4ed73. Read the comment docs.