NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Finish crafting implementation #297

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR finishes the implementation of crafting recipes.

Completed

codecov-io commented 7 years ago

Codecov Report

Merging #297 into master will increase coverage by 2.24%. The diff coverage is 18.54%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #297      +/-   ##
============================================
+ Coverage     13.61%   15.86%   +2.24%     
- Complexity      705      937     +232     
============================================
  Files           405      410       +5     
  Lines         12287    13775    +1488     
  Branches       1313     1536     +223     
============================================
+ Hits           1673     2185     +512     
- Misses        10497    11445     +948     
- Partials        117      145      +28
Impacted Files Coverage Δ Complexity Δ
src/main/java/nova/core/recipes/RecipeManager.java 88.88% <ø> (+35.55%) 13 <0> (+6) :arrow_up:
...ava/nova/core/recipes/crafting/CraftingRecipe.java 100% <ø> (+100%) 1 <0> (+1) :arrow_up:
...per/recipes/forward/NovaCraftingGridContainer.java 0% <ø> (ø) 0 <0> (?)
...a/nova/core/recipes/ingredient/ItemIngredient.java 100% <ø> (+100%) 4 <0> (+4) :arrow_up:
...va/nova/internal/core/dummy/CraftingGridDummy.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...per/recipes/forward/NovaCraftingGridContainer.java 0% <ø> (ø) 0 <0> (?)
...e/v17/wrapper/recipes/backward/MCCraftingGrid.java 0% <0%> (ø) 0 <0> (?)
...apper/mc/forge/v17/wrapper/item/ItemConverter.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../wrapper/recipes/forward/ShapelessRecipeBasic.java 0% <0%> (ø) 0 <0> (?)
...va/core/wrapper/mc/forge/v17/util/WrapUtility.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed4eabd...1f38aec. Read the comment docs.