NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Fix NOVA Core language files not loading #299

Open ExE-Boss opened 7 years ago

ExE-Boss commented 7 years ago

If a wrapper also defines a language file, then it will be ignored currently.

The Core and Wrapper language files should instead be merged, with the Wrapper language file contents following the Core language file contents, replacing Core lines where the Core and Wrapper language file key is equal.

To do list:


Ex. the following files should be merged like so:

Core some.lang:

core.foo=Core Foo
core.bar=Core Bar
core.baz=Core Baz

Wrapper some.lang:

(placement of core.bar is irrelevant)

wrapper.foo=Wrapper Foo
wrapper.bar=Wrapper Bar
wrapper.baz=Wrapper Baz
core.bar=Replaced Bar

Merged some.lang:

core.foo=Core Foo
core.bar=Replaced Bar
core.baz=Core Baz

wrapper.foo=Wrapper Foo
wrapper.bar=Wrapper Bar
wrapper.baz=Wrapper Baz
codecov-io commented 7 years ago

Codecov Report

Merging #299 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #299   +/-   ##
=========================================
  Coverage     13.59%   13.59%           
  Complexity      732      732           
=========================================
  Files           409      409           
  Lines         12788    12788           
  Branches       1354     1354           
=========================================
  Hits           1739     1739           
  Misses        10932    10932           
  Partials        117      117
Impacted Files Coverage Δ Complexity Δ
...ore/wrapper/mc/forge/v17/launcher/ClientProxy.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...ore/wrapper/mc/forge/v18/launcher/ClientProxy.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9389e0a...e31e513. Read the comment docs.