Closed ExE-Boss closed 7 years ago
Merging #301 into master will increase coverage by
0.25%
. The diff coverage is32.65%
.
@@ Coverage Diff @@
## master #301 +/- ##
============================================
+ Coverage 16.16% 16.42% +0.25%
- Complexity 897 931 +34
============================================
Files 413 413
Lines 13084 13130 +46
Branches 1377 1375 -2
============================================
+ Hits 2115 2156 +41
- Misses 10823 10830 +7
+ Partials 146 144 -2
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...r/mc/forge/v18/wrapper/block/backward/BWBlock.java | 0% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
...r/mc/forge/v17/wrapper/block/backward/BWBlock.java | 0% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
src/main/java/nova/core/block/Block.java | 8.88% <0%> (ø) |
3 <0> (ø) |
:arrow_down: |
src/main/java/nova/core/util/math/MathUtil.java | 98.96% <100%> (+16.87%) |
79 <26> (+34) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a33b6ee...5a2e2f3. Read the comment docs.
This PR changes the Block coordinate methods (
x()
,y()
andz()
) return type tolong
. This is needed for SuperNOVA and other voxel based games, which have larger worlds than Minecraft.Additional changes/fixes:
BWBlock.getMcBlockAccess()
toBWBlock.blockAccess()
BWBlock.blockPos()
in MC 1.8BWBlock.getTileEntity()
andBWBlock.getTileEntityImpl()
BWBlock.load(Data)