search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Change Player ID methods and their meaning #304

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

The way player IDs are currently implemented is counter-intuitive. This PR changes the following:

Method Old Meaning New Meaning
getUsername() + getPlayerID() → getUniqueID() The username of the player (can be changed in Minecraft) The unique ID for that specific account in the game on which the mod was installed (will never change)
getID() In Minecraft: the unique Mojang account UUID The ID specific to that component (identifying it from other components, as that is what it's used as by the Component class)
getDisplayName() → getUsername() + getDisplayName() Get the player's name displayed in the chat and other places (Unchanged)
codecov-io commented 7 years ago

Codecov Report

Merging #304 into master will decrease coverage by 0.01%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #304      +/-   ##
===========================================
- Coverage     16.42%   16.4%   -0.02%     
  Complexity      931     931              
===========================================
  Files           413     414       +1     
  Lines         13130   13140      +10     
  Branches       1375    1377       +2     
===========================================
  Hits           2156    2156              
- Misses        10830   10840      +10     
  Partials        144     144
Impacted Files Coverage Δ Complexity Δ
src/main/java/nova/core/component/Component.java 45.45% <ø> (ø) 3 <0> (ø) :arrow_down:
...mc/forge/v18/wrapper/entity/backward/BWEntity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../mc/forge/v18/wrapper/entity/forward/FWEntity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...c/main/java/nova/core/entity/component/Player.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...c/main/java/nova/core/util/UniqueIdentifiable.java 0% <0%> (ø) 0 <0> (?)
.../v18/wrapper/entity/forward/MCEntityTransform.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...mc/forge/v17/wrapper/entity/backward/BWEntity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../mc/forge/v17/wrapper/entity/forward/FWEntity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
src/main/java/nova/core/entity/Entity.java 25.8% <0%> (-8.98%) 6 <0> (ø)
.../v17/wrapper/entity/forward/MCEntityTransform.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c34713...33e65af. Read the comment docs.