search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Migrate dependencies to the Java Library Gradle plugin #314

Closed ExE-Boss closed 6 years ago

ExE-Boss commented 6 years ago

This migrates the dependencies of NOVA-Core to use the Java Library Plugin (see #313).

ExE-Boss commented 6 years ago

It’s because java-library requires Gradle 3+, but ForgeGradle 1.2 is incompatible with Gradle 4+.

codecov-io commented 6 years ago

Codecov Report

Merging #314 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #314   +/-   ##
=========================================
  Coverage     16.99%   16.99%           
  Complexity      965      965           
=========================================
  Files           416      416           
  Lines         13165    13165           
  Branches       1383     1383           
=========================================
  Hits           2237     2237           
  Misses        10782    10782           
  Partials        146      146
Impacted Files Coverage Δ Complexity Δ
src/main/java/nova/core/util/registry/Factory.java 48.14% <ø> (ø) 5 <0> (ø) :arrow_down:
...rc/main/java/nova/core/component/ComponentMap.java 54.05% <ø> (ø) 10 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 297857e...84cb535. Read the comment docs.

RX14 commented 6 years ago

Would be nice if you had time to work on the actual code instead of just mess with gradle :)

ExE-Boss commented 6 years ago

I have been working on the refactor/inventory branch, but that required this, NOVA-Team/NOVA-Gradle#16 and NOVA-Team/NOVA-Gradle#17 to be merged because of the ForgeGradle issues.

RX14 commented 6 years ago

Oh cool, nice to know.