search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Add CircleCI integration to NOVA-Core #319

Closed Temmie19 closed 6 years ago

Temmie19 commented 6 years ago

I mean. That pretty much sums it up. This should be everything we need, but I'll happily fix it if it ever needs it.

codecov-io commented 6 years ago

Codecov Report

Merging #319 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #319   +/-   ##
=========================================
  Coverage     16.99%   16.99%           
  Complexity      965      965           
=========================================
  Files           416      416           
  Lines         13165    13165           
  Branches       1383     1383           
=========================================
  Hits           2237     2237           
  Misses        10782    10782           
  Partials        146      146

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 689f58e...f2e290a. Read the comment docs.

Temmie19 commented 6 years ago

Oops

Temmie19 commented 6 years ago

And that URL in the gradle.properties wasn't actually still there. That was removed in the next commit anyways.

Temmie19 commented 6 years ago

So ./gradlew check doesn't apprarently work. At least not in CircleCI

ExE-Boss commented 6 years ago

That’s because of NOVA-Team/NOVA-Gradle#19.

The previous build passed because it didn’t run the tests, which isn’t what we want, because we need to run the tests.