search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Fix compiler warnings #321

Closed ExE-Boss closed 6 years ago

ExE-Boss commented 6 years ago

This PR fixes all remaining compiler warnings in the rest of NOVA-Core.

A lot of the warnings were related to either Javadoc or raw types, the rest were unchecked conversion.

Follow up to #278, fixes #184.

Also, the build is painfully slow (see https://github.com/NOVA-Team/NOVA-Core/issues/322).

codecov-io commented 6 years ago

Codecov Report

Merging #321 into master will decrease coverage by 0.02%. The diff coverage is 13.97%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #321      +/-   ##
============================================
- Coverage     16.99%   16.97%   -0.03%     
  Complexity      965      965              
============================================
  Files           416      416              
  Lines         13165    13176      +11     
  Branches       1383     1382       -1     
============================================
- Hits           2237     2236       -1     
- Misses        10782    10794      +12     
  Partials        146      146
Impacted Files Coverage Δ Complexity Δ
...ava/nova/core/component/transform/Orientation.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
.../main/java/nova/core/event/bus/EventException.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...rc/main/java/nova/core/render/RenderException.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
src/main/java/nova/core/network/NetworkTarget.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...e/wrapper/mc/forge/v18/wrapper/render/BWModel.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...per/mc/forge/v18/wrapper/block/BlockConverter.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...a/nova/core/recipes/ingredient/ItemIngredient.java 100% <ø> (ø) 4 <0> (ø) :arrow_down:
...e/wrapper/mc/forge/v18/launcher/ForgeLoadable.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...wrapper/mc/forge/v18/asm/lib/TemplateInjector.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
.../core/wrapper/mc/forge/v17/asm/lib/ObfMapping.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f241f25...bc6f1c9. Read the comment docs.