NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

feat: Refactor inventory #324

Open ExE-Boss opened 6 years ago

ExE-Boss commented 6 years ago

List of changes:

codecov[bot] commented 6 years ago

Codecov Report

Merging #324 into master will decrease coverage by 0.02%. The diff coverage is 1%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #324      +/-   ##
============================================
- Coverage     13.24%   13.21%   -0.03%     
- Complexity     1005     1006       +1     
============================================
  Files           532      532              
  Lines         17368    17429      +61     
  Branches       1803     1818      +15     
============================================
+ Hits           2301     2304       +3     
- Misses        14920    14978      +58     
  Partials        147      147
Impacted Files Coverage Δ Complexity Δ
.../java/nova/core/component/inventory/Inventory.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...c/forge/v1_11_2/wrapper/inventory/FWInventory.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...r/mc/forge/v1_8/wrapper/inventory/BWInventory.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...c/forge/v1_7_10/wrapper/inventory/BWInventory.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...r/mc/forge/v1_8/wrapper/inventory/FWInventory.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
src/main/java/nova/core/item/Item.java 30.95% <0%> (ø) 9 <0> (ø) :arrow_down:
...a/nova/core/component/inventory/InventoryView.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...c/forge/v1_11_2/wrapper/inventory/BWInventory.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...c/forge/v1_7_10/wrapper/inventory/FWInventory.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...nova/core/component/inventory/InventorySimple.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 605895b...50b379e. Read the comment docs.

RX14 commented 6 years ago

The original rule of thumb was that we accept nulls into arguments and return optionals.