NOtherDev / whatwebcando

An overview of the device integration HTML5 APIs
https://whatwebcando.today/
MIT License
836 stars 61 forks source link

Feature eyedropper #92

Closed fsciuti closed 2 years ago

fsciuti commented 2 years ago

Add EyeDropper API feature.

fsciuti commented 2 years ago

Looks good 🙂 Two minor spelling comments. Were you able to run the setup locally successfully @fsciuti ?

Yes...I used nvm to run Node lts/erbium, otherwise Sapper can't run correctly.

NOtherDev commented 2 years ago

Thank you @fsciuti ! I double checked the deploy instruction - it's npm run export and then npm run deploy. Go on and try it yourself - good luck! 💪

fsciuti commented 2 years ago

I tried but I received a lot of errors... I'll check soon and let you know!

NOtherDev commented 2 years ago

Ok it was only me who did it so far. I guess we'll have to go through the setup for the first time. The dist directory needs to be an independent (--orphan) checkout of the gh-pages branch.

fsciuti commented 2 years ago

Can you explain better?

fsciuti commented 2 years ago

Hi Adam, how are you? I have researched your solution but what do you think if we use a solution like one of these:

- @.***/deploying-sapper-pwa-using-github-pages-step-by-step-tutorial-part-1-1e9828dfe4de

I don't understand the reason for your choice on npm run export and npm run deploy scripts.

Thank you very much and I apologize for the inconvenience, but I want to publish a lot of new features! :)

NOtherDev commented 2 years ago

Yes @fsciuti, that would most probably work. I did what I came up with back then and used what was at my disposal back then 🙂 I'm happy to deploy Eyedropper myself now and let you prepare the new, easier deployment procedure in a separate PR 🚀 Would this work?

fsciuti commented 2 years ago

Great idea! Thank you...First I'll probably work on the new deployment and then on the migration from Sapper to SvelteKit.

NOtherDev commented 2 years ago

Deployed 💫

fsciuti commented 2 years ago

Thank you...I'll try the new deployment on a fork and a github page with no specific domain. I will be back soon! :D