search

NPBruce / valkyrie

Valkyrie GM for Fantasy Flight Board Games
Apache License 2.0
506 stars 105 forks source link

Bug on Amnesia setting investigator as dead #1070

Closed renancarlosdev closed 5 years ago

renancarlosdev commented 5 years ago

Description of Problem or Question

I was playing Amnesia scenario and one investigator died, I set it and the game didn't end on next turn

There was one question mark token(interaction token?) that didn't work too, next to the female npc on the kitchen after she left the room.

Valkyrie Version

2.1.2

redwolf2 commented 5 years ago

I've also seen this in V2.2.00b. "Investigator Eliminated" does not end the scenario.

scrubbless commented 5 years ago

Eliminated trigger worked fine with a strain on reality in 2.200b Android

screenshot_20190217-163850_valkyrie

I think this may just be an issue with Amnesia

BenRQ commented 5 years ago

Related to #946
It would be interesting to know what is done in the Amnesia scenario to understand if it's a bug in Valkyrie or if it was done on purpose in the scenario.

scrubbless commented 5 years ago

Hi @BenRQ

Its not a bug with Valkyrie from what I can see. Having a look at the Events.ini in Amnesia, there are no events that have the "trigger=Eliminated" trigger.

BenRQ commented 5 years ago

Well in that case, shouldn't we end the scenario automatically ? This is what I suggested in #946 but I understood from you answer that it was already implemented.

BenRQ commented 5 years ago

We should also ping the author @drinkinguranus so he can fix the scenario.

scrubbless commented 5 years ago

The Author has to create an event that triggers from "Eliminated" to place an outro in this situation. Nothing wrong on the valkyrie side here.

I am not sure how it would interact if Valkyrie intervened here. I wouldn't change it to do that personally.

I had an idea that could take advantage of this functionality, for example. If an investigator is eliminated, you could actually give the party an "extra life", by say spawning a token which gives the player a new investigator (similar to the locked rooms in Left4Dead) - then flagging Investigator Eliminated to 0. Its not something i've tested yet, but I've been toying with the idea in my head, as a way to crank up the severity of events to really make players feel hopeless. Having these "respawns" might be quite fun.

EDIT:

I also tested 2.2.00b in windows for the Eliminated trigger, and its fine - working as intended.

antontimmermans commented 5 years ago

I agree that this should be solved in the scenario itself. Not in Valkyrie. I will also add some tips in the tutorial on how to end a scenario including: sad endings (like investigator died, scenario loss), the almost won endings and ofcourse the happy endings (yes, I said it). created a ticket for it to later work on it: https://github.com/scrubbless/MoM2ndTutorial/issues/19

BenRQ commented 5 years ago

I'm closing this issue. Please raise your hand if you think it should be reopened :)

scrubbless commented 5 years ago

I'd leave it closed its and old thread and a fix the author needs to do. People can still comment on closed threads