search

NPBruce / valkyrie

Valkyrie GM for Fantasy Flight Board Games
Apache License 2.0
504 stars 105 forks source link

Fail to import SOME tiles, with no error message #1304

Open cebercoto opened 4 years ago

cebercoto commented 4 years ago

Description of Problem or Question

it fails to import some of the tiles, specifically in my experience from Call of the Wild: Cave Bend, Pig Pen, River Bend, Outhouse, Campsite. Any idea on how to solve this? when trying to use them in editor they appear only as name, not an image, and if selected they make Valkyrie crush. This behaviour is replicated in Windows and Android versions. Also, in Windows, I tried launching it with admin privileges.

many thanks

Valkyrie Version

2.4.09

scrubbless commented 4 years ago

Some of these tiles were never used in the official app, therefore don't have images.

There are scans in Valkyrie, but I am unsure where these are saved. Hopefully there isn't an issue there.

NPBruce commented 4 years ago

https://github.com/NPBruce/valkyrie/tree/master/unity/Assets/StreamingAssets/content/MoM/ck/cotw-tiles https://github.com/NPBruce/valkyrie/tree/master/unity/Assets/StreamingAssets/content/MoM/ck/fa-tiles https://github.com/NPBruce/valkyrie/tree/master/unity/Assets/StreamingAssets/content/MoM/ck/mom1e-tiles

scrubbless commented 4 years ago

It's working fine for me, but I did not do a clean install (delete all content and import).

I'll try that on another machine and see if I can reproduce.

scrubbless commented 4 years ago

Have you selected the content from the main menu when running this? If a scenario is not set to required in the scenario and you have not selected the content, it will crash when trying to place the tile.

So on a Save & Test if you don't own the content (selected in content from the main menu) and the scenario calls to place it, it will crash. You either have to add set the expansion as "a Requirement" on the main scenario quest, or you need to add tests to events that place expansion content checking if it has been enabled, e.g #cotwt == 1.

cebercoto commented 4 years ago

Hi, sorry I did not answer earlier. Yes, that makes sense (that these specific ones are not used by the app, are just legacy from the 1st edition game, and hence would not be imported from either the steam or android apps since they are not there to begin with).

Many thanks for this and for the fabulous work!