NPBruce / valkyrie

Valkyrie GM for Fantasy Flight Board Games
Apache License 2.0
506 stars 105 forks source link

[Bug] Continuing an Attack or Evade when the monster is fully damaged causes unintended behavior #1560

Open Hobbeslionheart opened 2 years ago

Hobbeslionheart commented 2 years ago

A clear and concise description of what the bug is.

Continuing an Attack or Evade when the monster is fully damaged causes unintended behavior. This leads to the finished or cancel button in the subsequent actions to not be able to be clicked which means the monster has to be defeated to advance which can be frustrating if accidentally clicked.

Steps to reproduce the behavior:

  1. Click on any monster.
  2. Increase their damage to the full capacity of the monster
  3. Click on Attack or Evade while the monster's health is full
  4. The Cancel Button or Finished button is grayed out, inactive.

A clear and concise description of what you expected to happen.

Either prevent an attack or an evade from happening when the monster's health is full or activate the button when the monster's health goes below maximum value.

Screenshots

image

Valkyrie Version

2.5.6

Hobbeslionheart commented 2 years ago

I'm working to fix this as I noticed this while fixing #1548 , but just logging the issue it for tracking purposes.

antontimmermans commented 2 years ago

Tested OK on 2.5.8a Windows build