NPBruce / valkyrie

Valkyrie GM for Fantasy Flight Board Games
Apache License 2.0
504 stars 105 forks source link

Request to add the $mythosIndoors check to some of the Mythos Events #761

Open NicolaZee opened 6 years ago

NicolaZee commented 6 years ago

A few Mythos Events could do with the check for indoors added.

Please can I go ahead and add the checks? If so, please can some kind soul advise me on the recommended way of setting up a development branch? I don't want to repeat my earlier mistake of editing live! I'm using the web interface of GitHub.

I plan to add the checks here: https://github.com/NPBruce/valkyrie/blob/master/unity/Assets/StreamingAssets/content/MoM/base/mythos.ini

I plan to add the indoor checks for the following Mythos Events RAT_SWARM_01
MYTHOS_EVENT_OM_NOM_02
MYTHOS_EVENT_YELLOW_WALLPAPER_02 MYTHOS_EVENT_WHO_PUT_A_WALL_HERE_01 MYTHOS_EVENT_WHO_PUT_A_WALL_HERE_02 MYTHOS_EVENT_TOO_MANY_DOORS_02 MYTHOS_EVENT_SHADOWS MYTHOS_EVENT_MADMEN_IN_THE_WALLS_01 MYTHOS_EVENT_MADMEN_IN_THE_WALLS_02 MYTHOS_EVENT_LOOSE_FLOORBOARD MYTHOS_EVENT_LANTERN_FIRE MYTHOS_EVENT_KNOCK_KNOCK_01 MYTHOS_EVENT_KNOCK_KNOCK_02 MYTHOS_EVENT_HULK_OUT MYTHOS_EVENT_HULK_OUT_ALT MYTHOS_EVENT_HELLO_WALL MYTHOS_EVENT_FEAR_OF_THE_UNKNOWN_01 MYTHOS_EVENT_FEAR_OF_THE_UNKNOWN_02 MYTHOS_EVENT_CREAK MYTHOS_EVENT_BAFFLING_VOICES MYTHOS_EVENT_BAFFLING_VOICES_ALT

In addition, can I add indoors to the following Mythos Event. [PerilIronCurse] 939 text={rnd:hero:{ffg:MYTHOS_EVENT_IRON_CURSE}:{0}:{ffg:MYTHOS_EVENT_IRON_CURSE_ALT}:{0}} 940 conditions=$mythosMinor,>,0 941 event1= 942 button1={ffg:UI_TAP_TO_CONTINUE} The trouble is I've written a murder mystery scenario and one of the suspects is a witch. The following mythos event could be very misleading: MYTHOS_EVENT_IRON_CURSE,"{0} feels a tearing pain in his throat. Coughing, he chokes up four iron nails and hears the faint laughter of a woman."

scrubbless commented 6 years ago

Awesome, getting your coding brain on Nicola? :D, appreciate your contributions!

NicolaZee commented 6 years ago

I've set-up a fork of NicolaZee/valkyrie which I plan to edit and then issue a pull request but I would like permission before I go ahead.

Thanks in advance

NicolaZee commented 6 years ago

An enhancement that could be useful for all scenarios would be the ability to add to a scenario a list of mythos events that are suitable for the scenario. That way unsuitable ones would not pop up.

e.g. MythosEvents.Ini could contain the list of Mythos Events suitable for the scenario and if it is blank than just ignore it and assume all Mythos Events are suitable

NPBruce commented 6 years ago

@NicolaZee I don't have a problem with the first change, I will do this for 2.1 if you don't get there first.

As for listing specific Mythos Events, the problem is that this list could change in the future. I have just added a few more from the latest FFG update, and some of the unfinished events may work in later version.

Also with a white list you will need to be careful that you still have events for the current threat level.

Perhaps I could let you call the inbuild mythos events directly, and you can handle them in the scenario without using the $mythos vars at all?

NicolaZee commented 6 years ago

Thanks Bruce

If you do have the time to add the flags that would be great. Thanks for the great work you and redwolf have done on SoA. Let's hope FFG slows down on the boxed releases!

Adding the functionality to call the mythos events direct is a great idea.

  1. People could mix together the inbuilt mythos events with their own.
  2. People could select the ones suitable

If you decide to implement this please can you, also, include a $mythos flag to turn off mythos events? That way people can turn off the mythos events, call up their own and turn them back on without needing to record the state of the existing, turn them all off and then restore them back to their original state.

BenRQ commented 5 years ago

Hi @NicolaZee, if you can send me the updated mythos.ini file, I will integrate it in next release.

Regarding [PerilIronCurse], I'm not sure I understand why this should be indoor? and why this is a problem with your scenario? I don't want to block the change of course, but I just want to understand why this is a problem for you.

Finally regarding the list of mythosEvents selection, I think it needs to be in a separate issue so we can track it better :)

BenRQ commented 5 years ago

Release 2.1 is coming. Moving this to 2.2

BenRQ commented 5 years ago

Waiting for your input on this issue @NicolaZee . Moving this to later version