search

NPI-D7 / BCSTM-Player

BCSTM-Player for 3ds
GNU General Public License v3.0
1 stars 0 forks source link

BCSTMs without loop points will loop to the beginning #1

Closed PlatinumLucario closed 2 years ago

PlatinumLucario commented 3 years ago

I can't see any reported issue on this, and while I haven't tried out the latest Nightly build to find out if it's still occurring, but NW4C Soundmaker Streamed Audio Binaries (BCSTM) without a loop points assigned in its data will continue to loop, instead of stopping when it gets to the end of the file. Only BCSTMs with loop points assigned in its data should be allowed to loop.

Edit: I have tested out the latest nightly, and it still has this issue.

tobid7 commented 3 years ago

I don't think that this is actually a bug or something because there's a bool function defined in the BCSTM header wether it should loop or not

tobid7 commented 3 years ago 
m_looping = read8();
m_blockLoopStart = loopPos / m_blockSampleCount;
m_blockLoopEnd = (loopEnd % m_blockSampleCount ? m_blockCount : loopEnd / m_blockSampleCount);

sample for loops

tobid7 commented 2 years ago

i found the problem and fixed it