Get rid of cf-units dependency

NPIOcean / kval

Tools for analysis and processing of ocean data in Python.

MIT License

2 stars 0 forks source link

Get rid of cf-units dependency #25

Closed oyvfoss closed 3 months ago

oyvfoss commented 3 months ago

This module is causing all kinds of compatibility issues:

Seems incompatile with numpy 2
Has to be installed from source for python 3.12
Seems incompatibel with MacOS?
Results in failing CI pipeline tests for mac_latest and windows_latest

Need to identify exactly where this is needed. Looks like they are working on it this year but I'd rather just drop it.

Does not seem to be a requirement of xarray (but may be an optional?)
cf-time does not seem to need it.

oyvfoss commented 3 months ago

.. ok, looks like the dependency comes from compliance-checker. Maybe we need some sort of conditional or optional dependency..

oyvfoss commented 3 months ago

Solved. compliance-checker is made optional dependency in pyproject.toml, and metadata.check_conventions throws appropriate errors if we try to run those functions.

After this, all tests seem to run well*:

On Ubuntu, Win* and Mac
Using numpy 2.0 (at least not requiring np<2)
On Python 3.12

*Fails with the combination Win + Py3.12, but that seems unrelated to this and will be addressed elsewhere.