ant_queen, lava_titan, and morvy all use deprecated mobs_redo function

[VAggrippino]

2017-05-01 02:03:54: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'nssm' in callback luaentity_Step(): ...0.4.15-0c34fe2-win64\bin\..\mods\nssm/mobs/ant_queen.lua:78: attempt to call global 'line_of_sight_water' (a nil value)
2017-05-01 02:03:54: ERROR[Main]: stack traceback:
2017-05-01 02:03:54: ERROR[Main]:   ...0.4.15-0c34fe2-win64\bin\..\mods\nssm/mobs/ant_queen.lua:78: in function 'custom_attack'
2017-05-01 02:03:54: ERROR[Main]:   ...etest-0.4.15-0c34fe2-win64\bin\..\mods\mobs_redo/api.lua:1784: in function 'do_states'
2017-05-01 02:03:54: ERROR[Main]:   ...etest-0.4.15-0c34fe2-win64\bin\..\mods\mobs_redo/api.lua:2380: in function <...etest-0.4.15-0c34fe2-win64\bin\..\mods\mobs_redo/api.lua:2273>

It looks like the line_of_sight_water function was removed from mobs_redo in a commit on 11th March 2017. I see the word "deprecated" in a comment, but I don't know anything else about it.

[taikedz]

Actually there are a lot of functions from MobsRedo that were exposed as global functions that have now been made local - this is a good thing.

The question is, what is the desired way to fix this? Possible resolutions:

• submit pull req to MobsRedo to make these accessible through the mobs: namespace, and make use of namespace in NSSM once fixed
• change in NSSM to make them no longer use these functions (loss in functionality?)
• state the version of MobsRedo that this NSSM was developed against, and mandate to only use that one? (acceptable, since MobsRedo has a tendency to change over time in non-backwards-compatible ways)

@NPXcoot would have to decide what they prefer ...

[taikedz]

On another note, NPXCoot did leave a version of mobs_redo in their own repo forks - probably that is the canonical one to use...