search

NPXcoot / nssm

Not So Simple Mobs mod for Minetest
14 stars 9 forks source link

Next API update make it adaptable #7

Closed taikedz closed 7 years ago

taikedz commented 7 years ago

I am looking at the code of the api.lua which has significantly diverged

Notably (in my use case anyway) a lack of support for the nametags, which is what I am after

However in trying to restore this functionality I can't help but notice that there are a lot of inserted bits of code, making it a bit of a spaghetti to update....!

May I humbly suggest moving functionality out to the nssm_api.lua file, and calling relevant functions there from chosen spots in the overriding api.lua , rather than adding whole chunks of code that confuse the diff tools? It makes it ever so difficult to keep in step with the original mobs_redo api and compatibility...

taikedz commented 7 years ago

Removing this issue.

This is exactly already how things are done. "real" mobs api has just moved on quite bit since this fork.