NPellet / visualizer

Other
42 stars 24 forks source link

Improve JSME event detection #1032

Open lpatiny opened 7 years ago

lpatiny commented 7 years ago

We had a problem to distinguish between 2 similar events when JSME load a molfile.

The molfile may be coming from a Drag&Drop, paste or a variable in but all the events yield to the same final event.

Seems Bruno did a new 'subevent' now that will allow us to distinguish between those different cases.

We need to remove the hacks in the code that allow to circumvent the problem:

https://github.com/NPellet/visualizer/blob/56161e17f9e3639f9ea5e52f0ea7097420c3d66b/src/modules/types/science/chemistry/jsme/controller.js#L212-L234

@stropitek I just put you as assignees so that you remind me this in case I forget ;)