Unit editor and remove value

NPellet / visualizer

Other

42 stars 24 forks source link

Unit editor and remove value #1101

Closed lpatiny closed 6 years ago

lpatiny commented 6 years ago

Currently if the unit is not specified there is an error and therefore no change. Nevertheless we would like:

[x] to remove everything
[x] to put just a new number and it should keep the current unit (or base if no current unit)

stropitek commented 6 years ago

When removing the value, should the new value be undefined or {unit: 'mm', SI: undefined}? I'm not sure which way to go, I see pros and cons to both

lpatiny commented 6 years ago

When it is a new value it is undefined so maybe remove everything should lead to the same result.