New bug: API.createData generates twice the trigger change

lpatiny commented 5 years ago

Version 2.104.0 has introduced a new bug. When a variable is created for the second time using API.createData(), 2 'triggerChange' are generated.

Compare the output in the following view between 2.104.0 and 2.103.0:

https://my.cheminfo.org/?viewURL=https%3A%2F%2Fmydb.cheminfo.org%2Fdb%2Fvisualizer%2Fentry%2Fc612978999b55cb77ebd3cfc947ebeb4%2Fview.json&v=v2.104.0

@targos Please could you help me for this ?

lpatiny commented 5 years ago

Based on bisect:

ca58f78d387622fd79080476ae46d35189e73204 is the first bad commit
commit ca58f78d387622fd79080476ae46d35189e73204
Author: Luc Patiny <luc@patiny.com>
Date:   Sun Jun 16 18:08:06 2019 +0200

    fix promise propagation bugs

:040000 040000 a534a14cf7d8073eabf9c4681aff85486e86c58a 88d55ab8ab2e228f4370d9f911091a9ab116951a M      src

https://github.com/NPellet/visualizer/commit/ca58f78d387622fd79080476ae46d35189e73204

I added a testcase and reverted variable.js to the previous version. This solves this specific problem.

lpatiny commented 4 years ago

Was fixed by the revert.

NPellet / visualizer

New bug: API.createData generates twice the trigger change #1129