NPellet / visualizer

Other
43 stars 23 forks source link

Same kind of api for UI.progress ? #983

Closed lpatiny closed 7 years ago

lpatiny commented 7 years ago

API.loading is a function that accepts id and message and can be stopped using 'stopLoading'

https://github.com/NPellet/visualizer/blob/master/src/src/util/api.js#L220

I would do the same for 'progress'

UI.progress(id, message) (message being optionnal and id becomes the message in that case) UI.stopProgress(id)

stropitek commented 7 years ago

There is already

var id = UI.startProgress(message);
UI.stopProgress(id);

It shows a notification bar indicating something is in progress. Not sure if this is what you are looking for

lpatiny commented 7 years ago

I know I just was thinking it should be the same kind of parameters and logic as API.loading