NPellet / visualizer

Other
43 stars 24 forks source link

jsGraph (spectra displayer) and X axis modification #997

Closed lpatiny closed 7 years ago

lpatiny commented 7 years ago

I could not let work the conversion of epoch to a time label. Seems the other conversions are also problematic

@NPellet Could be related to jsGraph itself ? image

NPellet commented 7 years ago

Probably, but the lines are not matching. You guys didn't update to the last version, I guess ?

2016-11-19 10:51 GMT+01:00 Luc Patiny notifications@github.com:

I could not let work the conversion of epoch to a time label. Seems the other conversions are also problematic

@NPellet https://github.com/NPellet Could be related to jsGraph itself ? [image: image] https://cloud.githubusercontent.com/assets/1484241/20454610/1ea03908-ae46-11e6-82ef-829ef14a7a6a.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NPellet/visualizer/issues/997, or mute the thread https://github.com/notifications/unsubscribe-auth/ABal23k8FY60RRQpwDYINv2JLZN4GEfJks5q_savgaJpZM4K3Nlh .

NPellet commented 7 years ago

Ah well anyway the time axis hasn't been migrated to ES6. It can indeed not work like that. Should be fixed by Monday.

2016-11-19 11:39 GMT+01:00 Norman Pellet norman.pellet@gmail.com:

Probably, but the lines are not matching. You guys didn't update to the last version, I guess ?

2016-11-19 10:51 GMT+01:00 Luc Patiny notifications@github.com:

I could not let work the conversion of epoch to a time label. Seems the other conversions are also problematic

@NPellet https://github.com/NPellet Could be related to jsGraph itself ? [image: image] https://cloud.githubusercontent.com/assets/1484241/20454610/1ea03908-ae46-11e6-82ef-829ef14a7a6a.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NPellet/visualizer/issues/997, or mute the thread https://github.com/notifications/unsubscribe-auth/ABal23k8FY60RRQpwDYINv2JLZN4GEfJks5q_savgaJpZM4K3Nlh .

NPellet commented 7 years ago

Normally fixed in 1.16.5.

Let me know if you still see some issues.

targos commented 7 years ago

I confirm it's fixed. Thanks.