search

NRC-Research / SNAP-issues

This repository was created to provide a public location to record and display the status of "issues" for the SNAP application. The SNAP developers will acknowledge, provide (and maybe request) feedback on the reported issues, and in general use the information to improve SNAP code.
3 stars 0 forks source link

External MELCOR Files in Job Stream #11

Closed AndrewIrelandNRC closed 2 years ago

AndrewIrelandNRC commented 2 years ago

The dialog for adding an external file to a job stream does not list MELCOR files.

The workaround for AptPlot stream steps appears to be adding a new file under the "input definitions" dialog. Here, the MELCOR files are an option. SNAP_Add_File SNAP_Edit_Plot_Inputs SNAP_external_file

NRCgg commented 2 years ago

Try using "Generic:ASCII" or "Generic:Binary" ?

NRCgg commented 2 years ago

@wrd-apt @jdr-apt @kroc-apt @dul-apt - any input on this? I feel that this is a non-issue due to ability to use the "Generic" options above. Ideas?

wrd-apt commented 2 years ago

It looks like that's a TRACE model. Currently file types are restricted by the model type you're currently in, so TRACE models only show files that are relevant to TRACE and coupled TRACE/PARCS calculations. The Engineering Template model and ASCII models support defining all types of files.

The AptPlot step has a work-around as you noted, where if you haven't defined the file type of an external file it will take the file type of the connected input file. The restriction of file types made sense at the time, but the AptPlot step came afterwards. Another work around is to use PyPost for your plotting, which allows you to load the files as you choose.

NRCgg commented 2 years ago

@NRC-Research/snap So it makes sense to close this issue?