search

NRC-Research / SNAP-issues

This repository was created to provide a public location to record and display the status of "issues" for the SNAP application. The SNAP developers will acknowledge, provide (and maybe request) feedback on the reported issues, and in general use the information to improve SNAP code.
3 stars 0 forks source link

SNAP 4.1.3 (Windows 10): bug in the generation of TRACE input deck with Numerics #48

Closed fmax85 closed 12 months ago

fmax85 commented 12 months ago

Good morning,

I noticed a bug when I try to launch a parametric job stream for a TRACE model. I have a TRACE model of a system where I am extensively using Numerics and a python functions to calculate non-interactive parameters (I need it because I am optimizing a design). In many of the PIPE components of the model the parameters as junction flow area, vol-avg flow area, D-hyd, cell length, etc. are input via Numerics variables. When I perform a tabular parametric job stream and then I look at the input decks of the single simulations I noticed that the parameters that need to be modified by the Numerics function are correctly implemented in the input deck, but the cell-average volume of the PIPEs, that I suppose should be internally calculated by the TRACE plugin, are not modified (despite the volume-averaged flow area is changed).

Below, I extract a snippet of the input deck of two cases of the parametric stream. The one on the right contains different input variables. The thin-line balloons show the values that are correctly calculated whilst the thick ones show the cell volume that is not changed, despite it is expected to.

Would it be possible to fix it? Additionally, is this behavior related to the SNAP version 4.1.3 only? If so, is there a way to revert to a previous version where this is not occurring?

Thanks in advance!

Regards

Fabio

snap413_errExportInputDeck

WDunsford commented 12 months ago

This issue has been addressed and will be included in the next version of the TRACE Plug-in. This update will ensure that the calculated property, identified with the ALV Flag in the component geometry dialog, will be recalculated immediately before exporting the component to ASCII. This will update ASCII Views, the validation display and ASCII file generation.