search

NRC-Research / SNAP-issues

This repository was created to provide a public location to record and display the status of "issues" for the SNAP application. The SNAP developers will acknowledge, provide (and maybe request) feedback on the reported issues, and in general use the information to improve SNAP code.
3 stars 0 forks source link

SNAP 4.1.4: issue with the TRACE plugin when using LUA scripting with patch-8 model #65

Closed fmax85 closed 6 months ago

fmax85 commented 7 months ago

Good morning,

I noticed an issue concerning the SNAP support to embed LUA scripting in TRACE patch-8 models. Below, I attach some figures of the input deck of the same sample test: on the left is the working model (drafted with a text editor), on the right is the input model generated with SNAP.

Thank you in advance!

Fabio

snap_lua_3 snap_lua_1 snap_lua_2

NRCgg commented 7 months ago

@fmax85 Thanks for the report! Can you please give this a try with the new SNAP 4.2.0 distribution as well?

Thanks in advance!

fmax85 commented 7 months ago

I tried with version 4.2.0 but I face the same issues

NRCgg commented 7 months ago

@fmax85 I discussed this problem further with @dul-isl and learned that there was a misunderstanding about how the LUA scripts would be added. This will be fixed in the next SNAP-TRACE plugin version.

I am leaving this issue open until it is confirmed that the next release fixes this issue.

Details

[Reference Notes from ISL-NRC meeting regarding this issue.](https://github.com/NRC-Research/SNAP-contract-notes/blob/main/development-contract-notes/Meeting-notes/20231115-biweekly.md)

WDunsford commented 6 months ago

This has been resolved in TRACE Plug-in version 4.6.2 released 12-19-2023