search

NRCHKB / node-red-contrib-homekit-bridged

Node-RED Contribution - HomeKit Bridged : Node-RED nodes to simulate Apple HomeKit devices.
https://nrchkb.github.io
MIT License
416 stars 52 forks source link

Fix Discord notifiction for dev workflow #382

Closed Shaquu closed 3 years ago

Shaquu commented 3 years ago

Looks like even if publish is skipped then discord is notified about new release.

Is

Wrong

  1. package.json version is 1.3.0
  2. There is no npmjs.com publish due to rule contains(env.PACKAGE_VERSION, 'dev') == true
  3. Discord is notified, but there is no new dev release

Correct

  1. package.json version is 1.3.0-dev.0
  2. There is npmjs.com publish due to rule contains(env.PACKAGE_VERSION, 'dev') == true
  3. Discord is notified as there is a new release

Should be:

Correct

  1. package.json version is 1.3.0
  2. There is no npmjs.com publish due to rule contains(env.PACKAGE_VERSION, 'dev') == true
  3. Discord is NOT notified as there is no new dev release

Correct

  1. package.json version is 1.3.0-dev.0
  2. There is npmjs.com publish due to rule contains(env.PACKAGE_VERSION, 'dev') == true
  3. Discord is notified as there is a new release