search

NRCHKB / node-red-contrib-homekit-bridged

Node-RED Contribution - HomeKit Bridged : Node-RED nodes to simulate Apple HomeKit devices.
https://nrchkb.github.io
MIT License
412 stars 52 forks source link

allChars: properties have spaces in names #496

Closed TheNON75 closed 1 year ago

TheNON75 commented 1 year ago

NRCHKB Plugin Version

1.4.3

Node JS Version

16

NPM Version

Official docker

Node-RED Version

2.x

Operating System

Official docker

What happened?

Periwrty names in allChars have spaces between the words unlike the properties used in the payload or accessory configuration. Spaces should be removed to stay consistent

How to reproduce?

Check allChars in any msg

Expected behavior:

Spaces to be removed

Additional comments?

N/A

Relevant log output

No response

Shaquu commented 1 year ago

Please test in 1.5.dev

Cyberbeni commented 1 year ago

This was a breaking change btw.

crxporter commented 1 year ago

Yes - kind of was breaking but ...

We decided it was a bugfix for the allChars property which was new in 1.4. The reasoning for this is everywhere else we use the property names, they have spaces removed. Spaces should have been removed in allChars the whole time but we didn't catch it before releasing the allChars feature.

In internal discussions (shaquu and I) decided this approach. Sorry for the breaking change, I had to change my flows in one spot also. Hope it didn't cause too much stress!!

Also closing since 1.5.0 is released.